Add Puppetserver catalog v4 API support#228
Merged
ahayworth merged 10 commits intogithub:masterfrom Dec 18, 2020
Merged
Conversation
996e85c to
452059f
Compare
Contributor
Author
|
I re-ran the CI job and it passed. I don't know why the results are not updating above, but you can see the results here: https://github.com/seanmil/octocatalog-diff/actions/runs/372918628 |
ahayworth
reviewed
Dec 16, 2020
Contributor
ahayworth
left a comment
There was a problem hiding this comment.
Thank you so much for this - its a lot of work, and I appreciate you bringing octocatalog-diff into the modern era!
I had a few questions, mainly because I'm just not as familiar with modern puppet.
spec/octocatalog-diff/tests/cli/options/puppet_master_token_file_spec.rb
Outdated
Show resolved
Hide resolved
Co-authored-by: Andrew Hayworth <[email protected]>
…le_spec.rb Co-authored-by: Andrew Hayworth <[email protected]>
Update docs per feedback provided by Andrew Hayworth in the PR.
ahayworth
approved these changes
Dec 18, 2020
Contributor
|
This is excellent - thank you so much for the contributions 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This pull request introduces support for the Puppetserver v4 catalog API, introduced in Puppetserver 6.3.0.
This new API endpoint offers additional capabilities and options not present in earlier API versions. In particular, updating facts and catalogs with PuppetDB as part of the compile is now optional. For Puppet Enterprise customers, you may use PE RBAC tokens to authenticate for v4 catalog compiles.
Checklist
rakein your checkout directory, or review the CI job triggered whenever you push to a pull request.rake coverage:specor ignoring untestable sections of code with# :nocovcomments. If you need help getting to 100% coverage please ask; however, don't just submit code with no tests..gemfile into the vendor/cache directory.