Skip to content
This repository was archived by the owner on Feb 13, 2023. It is now read-only.

Fix misleading validation message#214

Merged
zkoppert merged 1 commit intogithub:fix-misleading-validation-messagefrom
ineffyble:fix-misleading-validation-message
Dec 17, 2020
Merged

Fix misleading validation message#214
zkoppert merged 1 commit intogithub:fix-misleading-validation-messagefrom
ineffyble:fix-misleading-validation-message

Conversation

@ineffyble
Copy link
Copy Markdown
Contributor

@ineffyble ineffyble commented Dec 17, 2020

Proposed Changes

  • If validation of Pull Request Title fails because there was no artifacts in the title, tell the user there were no artifacts in the title, instead of saying there were no artifacts in the body.

Reviewer Checklist

  • If a functional change has occurred, testing the integration has been performed
  • This PR has been categorized with a label (1 of automation, bug, documentation, enhancement, infrastructure, or performance) for the changelog

Copy link
Copy Markdown
Member

@zkoppert zkoppert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻 That seems to make it consistent with the rest of the function. Thank you!

@zkoppert
Copy link
Copy Markdown
Member

I'm going to merge this into another branch so that we can make sure that CI passes. The status check won't run from a fork for some reason. Thanks for the contribution @ineffyble! 🎉

@zkoppert zkoppert changed the base branch from main to fix-misleading-validation-message December 17, 2020 04:37
@zkoppert zkoppert merged commit 2946626 into github:fix-misleading-validation-message Dec 17, 2020
@zkoppert zkoppert mentioned this pull request Dec 17, 2020
3 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants