Skip to content
This repository was archived by the owner on Feb 13, 2023. It is now read-only.

Create App Manifest#83

Closed
primetheus wants to merge 2 commits intomainfrom
primetheus/app-manifest
Closed

Create App Manifest#83
primetheus wants to merge 2 commits intomainfrom
primetheus/app-manifest

Conversation

@primetheus
Copy link
Copy Markdown
Contributor

@primetheus primetheus commented Aug 11, 2020

Closes #79

Proposed Changes

  • app.yml for the App manifest flow

Readiness Checklist

  • If this change requires documentation, it has been included in this pull request

IAmHughes
IAmHughes previously approved these changes Aug 11, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@IAmHughes IAmHughes left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as is, but if we wanted to update documentation in the README about setup using the manifest file, should we put it here or in a new PR?

EDIT: 🤦‍♂️ realized this is a draft, haha. Still approving from this point of the PR at least 😋

@zkoppert zkoppert added the infrastructure dependencies and internal maintenance label Aug 14, 2020
@primetheus primetheus mentioned this pull request Aug 17, 2020
Merged
@primetheus
Copy link
Copy Markdown
Contributor Author

primetheus commented Aug 17, 2020

To make this work, there needs to be an environment variable set for GHE_HOST=github.example.com, and then you navigate to http://<host>:3000 and finish the setup for GitHub. At present, this manifest does not seem to be populating the GitHub App configuration

@github-actions
Copy link
Copy Markdown

github-actions bot commented Sep 17, 2020

This pull request has been automatically marked as stale because it has not had recent activity.
It will be closed in 14 days if no further activity occurs.
Thank you for your contributions.

If you think this pull request should stay open, please remove the O: stale 🤖 label or comment on the pull request.

@primetheus primetheus added WIP Work In Progress enhancement New feature or request and removed O: stale 🤖 labels Sep 18, 2020
@github-actions
Copy link
Copy Markdown

github-actions bot commented Oct 19, 2020

This pull request has been automatically marked as stale because it has not had recent activity.
It will be closed in 14 days if no further activity occurs.
Thank you for your contributions.

If you think this pull request should stay open, please remove the O: stale 🤖 label or comment on the pull request.

@github-actions github-actions bot closed this Nov 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@zkoppert zkoppert Awaiting requested review from zkoppert zkoppert will be requested when the pull request is marked ready for review zkoppert is a code owner

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

1 more reviewer

@IAmHughes IAmHughes IAmHughes left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

enhancement New feature or request infrastructure dependencies and internal maintenance O: stale 🤖 WIP Work In Progress

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Create an App Manifest

3 participants

@primetheus @IAmHughes @zkoppert