This repository was archived by the owner on May 30, 2024. It is now read-only.
Conversation
added 11 commits
October 9, 2021 16:01
noahingh
commented
Oct 10, 2021
Comment on lines
+72
to
+84
| if len(c.cache) == 0 { | ||
| c.log.Debug("List all deployment_count.") | ||
| if dcs, err = c.i.ListAllDeploymentCounts(ctx); err != nil { | ||
| c.log.Error("It has failed to list all deployment_counts.", zap.Error(err)) | ||
| return | ||
| } | ||
| } else { | ||
| c.log.Debug("List deployment_count from the last time.", zap.Time("last", c.lastTime)) | ||
| if dcs, err = c.i.ListDeploymentCountsGreaterThanTime(ctx, c.lastTime); err != nil { | ||
| c.log.Error("It has failed to list deployment_counts.", zap.Error(err)) | ||
| return | ||
| } | ||
| } |
Member
Author
There was a problem hiding this comment.
When it initializes, it lists all deployment_counts and caches them. After the next collection, it only lists updated records.
Comment on lines
+125
to
+133
| name: namespace | ||
| required: true | ||
| schema: | ||
| type: integer | ||
| description: The repository id | ||
| type: string | ||
| - in: path | ||
| name: name | ||
| required: true | ||
| schema: | ||
| type: string |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the
deployment_counttable to collect the statistics data, and it expects better performance than producing statistics from thedeploymenttable.Metrics