Skip to content

Fixing a lot of identation and adding infowindows object#28

Closed
sgonzaloc wants to merge 6 commits intogmplot:masterfrom
sgonzaloc:master
Closed

Fixing a lot of identation and adding infowindows object#28
sgonzaloc wants to merge 6 commits intogmplot:masterfrom
sgonzaloc:master

Conversation

@sgonzaloc
Copy link
Copy Markdown

I have fixed a lot of identation in javascript code so is easier to understand this code when you see the HTML file, and I have also added the infowindows to markers in gmplot.

Please add this function to this repository because it was very useful for me and i would like to share it

@sandrotosi
Copy link
Copy Markdown
Contributor

infowindows are already part of #15

@sgonzaloc
Copy link
Copy Markdown
Author

Yes, I know, but now is not part of master branch. Furthermore, I found some problems with that implementation. I wrote the code thinking in Google Maps API example in his oficial website. The attachment to a marker is optional and in that implementation is not, so I have returned the marker name to be able to work with that, and make the anchor to a marker, and I have added an example in the README rst file. The identation was wrong implemented in that implementation. The name of some variables follow another convention, comparing with the other variables of this code. I have added the option of open a map with the infowindows visibles from beggining, so you can see all the infowindows visibles from the loading of the website.

Moreover, I have fixed a lot of identation so now is easier to read the HTML file.

@vgm64 vgm64 force-pushed the master branch 7 times, most recently from 823e3ad to ad6df42 Compare March 4, 2018 07:22
@sandrotosi sandrotosi removed their assignment May 18, 2020
@frslm frslm added the duplicate Duplicate of some other item. label Jun 7, 2020
@frslm
Copy link
Copy Markdown
Contributor

frslm commented Jun 7, 2020

Will close this as a duplicate of #119, since that PR creates InfoWindows tied to a Marker in one step, without needing the user to manage markers on their end.

@frslm frslm closed this Jun 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

duplicate Duplicate of some other item.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants