Closed
Conversation
scgm0
approved these changes
Apr 9, 2023
Collaborator
|
I don't think this is a good idea to add statics new methods to godot classes. |
Collaborator
|
I don't think @Geequlim agrees with this design, and there has been no activity. Ok to close? |
Collaborator
|
Closing due to lack of support from a maintainer. Feel free to comment or revise. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request would implement the new function.
This will create a more convenient API for instantiating JavaScript classes in GDScript.
For example:
This is related to #107
There is a few things that I am not happy about with this implementation, though.
Looking forward to review and suggestions.