Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request establishes the foundational configuration for managing Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces the necessary release-please configuration files for managing version 2 releases. The setup correctly defines a Python package, uses prerelease alpha versioning, and separates the changelog into CHANGELOG-v2.md. The changelog-sections are well-defined, hiding less critical commit types from the public changelog.
| "prerelease-type": "alpha", | ||
| "package-name": "google-adk", | ||
| "include-component-in-tag": false, | ||
| "skip-github-release": true, |
There was a problem hiding this comment.
The skip-github-release option is set to true. While this might be intentional for an initial alpha phase, it means that release-please will not create GitHub releases for v2. If the intention is to eventually publish releases on GitHub, this setting will need to be changed. Please confirm if skipping GitHub releases is the desired long-term behavior for v2, or if this is a temporary measure.
In addition this adds a workflow to automatically create PRs to merge v1 into v2