This repository was archived by the owner on Dec 29, 2022. It is now read-only.
Add a go.mod file for basic Go modules support.#1
Merged
hjfreyer merged 1 commit intogoogle:masterfrom Feb 13, 2019
creachadair:gomod
Merged
Add a go.mod file for basic Go modules support.#1hjfreyer merged 1 commit intogoogle:masterfrom creachadair:gomod
hjfreyer merged 1 commit intogoogle:masterfrom
creachadair:gomod
Conversation
Also adds a conventional import comment, to document the expected import path.
Contributor
|
I haven't actually worked with Go modules before, so having a co-worker take a look. Should get back later today! |
Contributor
Author
Thanks! Please let me know if you or they have any questions. Since this package is self-contained, the configuration is trivial—the main thing to make it work well will be adding one or more release tags. |
Contributor
|
Tagged by creating a release: https://github.com/google/orderedcode/releases/tag/v0.0.1 Thanks for the change! Let me know if anything else needs changing. |
Contributor
Author
|
Thanks! Everything looks sound from my side. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to work well with Go modules, a package should have a
go.modfile and semantic version tags on release versions. I have provided a rudimentarygo.modfile here. Assuming you accept this change, and if you are willing to alsogit tag v0.0.1 masterafter it is merged, that would start the release history.If the API of the package is considered stable, you could instead use
v1.0.0, but at that point module users will expect breaking changes to increment the major version. I don't have a clear sense of how much this package is maintained, sov0would be a safe default for now.