Skip to content
This repository was archived by the owner on Jan 10, 2023. It is now read-only.

ADB over TCP#1

Merged
alusco merged 5 commits intogoogle:masterfrom
cambridgehackers:adb-over-tcp
Oct 15, 2014
Merged

ADB over TCP#1
alusco merged 5 commits intogoogle:masterfrom
cambridgehackers:adb-over-tcp

Conversation

@jameyhicks
Copy link
Contributor

This patch adds support to connect to the android device over TCP.

@fahhem
Copy link
Contributor

fahhem commented Oct 13, 2014

I thought this would be this easy when I wrote it, but I never bothered to check. Thanks!

Can you also add a way to connect to a remote IP via adb_debug.py?

@jameyhicks
Copy link
Contributor Author

I'll submit a new pull request because I do not see a way to revise this one.

@jameyhicks jameyhicks force-pushed the adb-over-tcp branch 2 times, most recently from 2dbab7f to ad8f379 Compare October 13, 2014 16:32
@fahhem
Copy link
Contributor

fahhem commented Oct 13, 2014

You can alter the commits and push them, I believe. I'm sure github has an
faq on the matter.
On Oct 13, 2014 9:28 AM, "Jamey Hicks" [email protected] wrote:

I'll submit a new pull request because I do not see a way to revise this
one.


Reply to this email directly or view it on GitHub
#1 (comment).

@jameyhicks
Copy link
Contributor Author

I was expecting behavior more like Gerrit. I guess pushing to the branch is enough. Cool!

@alusco
Copy link
Contributor

alusco commented Oct 13, 2014

Nice thanks, I'll take a look this afternoon but if Farz says it looks good then it shouldn't be an issue.

Thanks!

@alusco
Copy link
Contributor

alusco commented Oct 14, 2014

Awesome I had like two comments, I'm not 100% sure I've done it right since I'm not used to PR's from Github but if you can make those minor changes we can merge it.

@jameyhicks
Copy link
Contributor Author

Simple enough. Updated!

@jameyhicks
Copy link
Contributor Author

I haven't had a problem where timeout was needed in the TCP handle.

We do run a timelimit for the duration of a shell command.

@alusco
Copy link
Contributor

alusco commented Oct 14, 2014

Awesome thanks!

@alusco
Copy link
Contributor

alusco commented Oct 14, 2014

Actually one last thing before I can merge this, apparently to merge in public code back into the project I need you to sign a CLA. It looks like it takes two seconds: https://cla.developers.google.com/about/google-individual

@jameyhicks
Copy link
Contributor Author

No problem. Signed individual Google CLA.

On Tue, Oct 14, 2014 at 4:46 PM, Alex Lusco [email protected]
wrote:

Actually one last thing before I can merge this, apparently to merge in
public code back into the project I need you to sign a CLA. Once you do
that I can merge it. It looks like it takes two seconds could you do that
for me: https://cla.developers.google.com/about/google-individual


Reply to this email directly or view it on GitHub
#1 (comment).

@alusco
Copy link
Contributor

alusco commented Oct 15, 2014

Thanks!

alusco added a commit that referenced this pull request Oct 15, 2014
@alusco alusco merged commit bcc09c8 into google:master Oct 15, 2014
@jameyhicks jameyhicks deleted the adb-over-tcp branch October 17, 2014 20:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants