Conversation
|
I thought this would be this easy when I wrote it, but I never bothered to check. Thanks! Can you also add a way to connect to a remote IP via adb_debug.py? |
|
I'll submit a new pull request because I do not see a way to revise this one. |
2dbab7f to
ad8f379
Compare
|
You can alter the commits and push them, I believe. I'm sure github has an
|
|
I was expecting behavior more like Gerrit. I guess pushing to the branch is enough. Cool! |
|
Nice thanks, I'll take a look this afternoon but if Farz says it looks good then it shouldn't be an issue. Thanks! |
|
Awesome I had like two comments, I'm not 100% sure I've done it right since I'm not used to PR's from Github but if you can make those minor changes we can merge it. |
|
Simple enough. Updated! |
d8dfe29 to
b3c420b
Compare
|
I haven't had a problem where timeout was needed in the TCP handle. We do run a timelimit for the duration of a shell command. |
|
Awesome thanks! |
|
Actually one last thing before I can merge this, apparently to merge in public code back into the project I need you to sign a CLA. It looks like it takes two seconds: https://cla.developers.google.com/about/google-individual |
|
No problem. Signed individual Google CLA. On Tue, Oct 14, 2014 at 4:46 PM, Alex Lusco [email protected]
|
|
Thanks! |
This patch adds support to connect to the android device over TCP.