Skip to content

Run asyncio coroutines #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
robweiss wants to merge 5 commits into from
Closed

Run asyncio coroutines #127

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
145ea98
Run asyncio coroutines
robweiss Jun 14, 2018
b35e367
Add support for python 3.4
robweiss Jun 14, 2018
7971d7f
Fix styling issue where line was too long
robweiss Jun 14, 2018
0fed4df
Disable pylint import error for asyncio import
robweiss Jun 14, 2018
56bea93
Merge branch 'master' into run_coroutines
dbieber Feb 29, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion fire/core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -669,7 +669,16 @@ def _CallAndUpdateTrace(component, args, component_trace, treatment='class',
fn = component.__call__ if treatment == 'callable' else component
parse = _MakeParseFn(fn, metadata)
(varargs, kwargs), consumed_args, remaining_args, capacity = parse(args)
component = fn(*varargs, **kwargs)

if six.PY34:
import asyncio # pylint: disable=import-error
if asyncio.iscoroutinefunction(fn):
loop = asyncio.get_event_loop()
component = loop.run_until_complete(fn(*varargs, **kwargs))
else:
component = fn(*varargs, **kwargs)
else:
component = fn(*varargs, **kwargs)

if treatment == 'class':
action = trace.INSTANTIATED_CLASS
Expand Down
5 changes: 5 additions & 0 deletions fire/fire_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,6 +265,11 @@ def testFireKeywordArgsWithMissingPositionalArgs(self):
fire.Fire(tc.Kwargs, command=['run', 'Hello', '--cell', 'ok']),
('Hello', None, {'cell': 'ok'}))

@unittest.skipUnless(six.PY34, 'Asyncio only available in Python 3.4+')
def testFireAsyncio(self):
self.assertEqual(fire.Fire(tc.py3.WithAsyncio,
command=['double', '--count', '5']), 10)

def testFireObject(self):
self.assertEqual(
fire.Fire(tc.WithDefaults(), command=['double', '--count', '5']), 10)
Expand Down
9 changes: 9 additions & 0 deletions fire/test_components_py3.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,9 @@

# Lint as: python3
"""This module has components that use Python 3 specific syntax."""
import six

import asyncio
import functools


Expand Down Expand Up @@ -43,3 +45,10 @@ def lru_cache_in_class(self, arg1):
@functools.lru_cache()
def lru_cache_decorated(arg1):
return arg1


class WithAsyncio(object):

@asyncio.coroutine
def double(self, count=0):
return 2 * count