Skip to content

Organization Structure Project#2

Closed
elinaldosoft wants to merge 4 commits intogoogle:masterfrom
elinaldosoft:master
Closed

Organization Structure Project#2
elinaldosoft wants to merge 4 commits intogoogle:masterfrom
elinaldosoft:master

Conversation

@elinaldosoft
Copy link
Copy Markdown

Organization structure tests.

@googlebot
Copy link
Copy Markdown
Collaborator

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@elinaldosoft
Copy link
Copy Markdown
Author

I signed it

@googlebot
Copy link
Copy Markdown
Collaborator

CLAs look good, thanks!

@@ -0,0 +1 @@
ipython No newline at end of file
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why add a requirements file for this?
It is already included in the install_requires argument for setup() in setup.py.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To configure the environment in development mode, But I believe the file name should be
requirements_dev.txt. What do you think ?

Copy link
Copy Markdown

@datashaman datashaman Mar 8, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks

stephenvincent27 added a commit to stephenvincent27/python-fire that referenced this pull request Jan 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants