Added hijack scroll function#197
Conversation
|
@istarkov Any thoughts on this PR? |
|
Thank you for contribution, IMO this must be done in the other not so hackable way.
Why? Im sure no one need this.
It is the case, and it is almost the same case as for When I create draggable markers, I need to disable map drag when I hover over the marker. I think all I need is just to allow |
|
PS: I'm on vacation now for next week or two, so I can answer fast only on simple issues and PRs as most time I use mobile phone for reading this. |
|
@istarkov Ah yeap, I agree, that's a better solution in some respects, though I think it has the implication of requiring one to move the logic to mouseEnter + mouseLeave (since otherwise by the time you try to catch the scroll event, it will have already propogated to gMaps so turning it off does nothing) The frustrating thing about this, is that googleMaps has no support for mouseOver/mouseOut, just mouseEnter/mouseLeave which means these events trigger will trigger frequently as you move over a popup Enjoy your vacation! |
|
@istarkov is the dynamic options something you're currently working on already? Otherwise, I might have a go at implementing it and submitting a new PR. |
|
@alex-e-leon It will be great if you make such PR. Thank you! |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
@istarkov I've added a hijack scroll function that allows you to manipulate the scroll event
I couldn't find any PR instructions so please let me know if there's any issues or if you'd like me for example to write tests.
Example uses:
Also note that I've added some example functions into the demo files to show how it works, but because the demo maps call
setMapParamsononChangeevents you don't get a smooth zoom change but instead get a slightly slower zoom change from changing the zoom props.I can remove these from the demo if you like but thought it might be useful for you to test.