Skip to content

Reset Bounds when surrounding div resizes#219

Merged
istarkov merged 9 commits intogoogle-map-react:masterfrom
RUPOJS:master
Aug 22, 2016
Merged

Reset Bounds when surrounding div resizes#219
istarkov merged 9 commits intogoogle-map-react:masterfrom
RUPOJS:master

Conversation

@RUPOJS
Copy link
Copy Markdown
Contributor

@RUPOJS RUPOJS commented Aug 22, 2016

@istarkov
Copy link
Copy Markdown
Collaborator

istarkov commented Aug 22, 2016

Wow! Super!
I'll check it later today, but what I see now is really cool.

@istarkov
Copy link
Copy Markdown
Collaborator

istarkov commented Aug 22, 2016 •
edited
Loading

Please add /* eslint-disable */ at the top of third-party libs, to pass through the travis checks

@RUPOJS
Copy link
Copy Markdown
Contributor Author

RUPOJS commented Aug 22, 2016

Thanks @istarkov .
I'll add that in next commit. Looking forward for your valuable feedback :)

istarkov
istarkov reviewed Aug 22, 2016
View reviewed changes
develop/GMapResizable.js
onChildMouseEnter={onChildMouseEnter}
onChildMouseLeave={onChildMouseLeave}
resetBoundsOnResize={true}
apiKey={"AIzaSyC-BebC7ChnHPzxQm7DAHYFMCqR5H3Jlps"}
Copy link
Copy Markdown
Collaborator

@istarkov istarkov Aug 22, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you really want to share your API key with all world?

Copy link
Copy Markdown
Contributor Author

@RUPOJS RUPOJS Aug 22, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its a dummy project with basic settings, so no harms in sharing it.

istarkov
istarkov reviewed Aug 22, 2016
View reviewed changes
src/utils/shallowEqual.js Outdated
@@ -0,0 +1,51 @@
/* eslint-disable */
Copy link
Copy Markdown
Collaborator

@istarkov istarkov Aug 22, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the last step is to delete this file?

@istarkov
Copy link
Copy Markdown
Collaborator

istarkov commented Aug 22, 2016

I found how to trigger internal gmap resize
please check that it will fix all issues

Please replace your _mapDomResizeCallback with this

  _mapDomResizeCallback = () => {
    this.resetSizeOnIdle_ = true;
    if (this.maps_) {
      this.maps_.event.trigger(this.map_, 'resize');
    }
  }

looks like it works perfectly for me

@RUPOJS
Copy link
Copy Markdown
Contributor Author

RUPOJS commented Aug 22, 2016

Hi @istarkov I did the suggested changes in the last commit :)

@istarkov istarkov merged commit e196e9f into google-map-react:master Aug 22, 2016
@istarkov
Copy link
Copy Markdown
Collaborator

istarkov commented Aug 22, 2016

Thank you!!!
Really good PR, and solve a real problem

@istarkov
Copy link
Copy Markdown
Collaborator

istarkov commented Aug 22, 2016

npm 0.18.0

@istarkov istarkov mentioned this pull request Aug 22, 2016
Closed
@istarkov istarkov mentioned this pull request Aug 31, 2016
Closed
@lustrousgorilla lustrousgorilla mentioned this pull request Oct 12, 2016
Open
@lock
Copy link
Copy Markdown

lock bot commented Dec 1, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Dec 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@RUPOJS @istarkov @Heedster