Keep original center on _mapDomResizeCallback#282
Merged
istarkov merged 1 commit intogoogle-map-react:masterfrom Nov 24, 2016
Merged
Keep original center on _mapDomResizeCallback#282istarkov merged 1 commit intogoogle-map-react:masterfrom
istarkov merged 1 commit intogoogle-map-react:masterfrom
Conversation
When the resize event is triggered, the original center was lost. This issue is significant when the map is renders outside visible dom with zero height and width. When placed into the visible dom, the resize is triggered correctly. With this change the center will persist. (Without this fix the old center is the top left corner)
Collaborator
|
Any picture? Or jsbin example please with the problem |
Contributor
Author
Collaborator
|
I see, thank you!!! |
Collaborator
Contributor
Author
|
Thanks for the quick response, though I made a small mistake. I opened a new pull request. #283 |
|
@istarkov I tried to use the How can I make sure that if I resize the map's container the center (and my marker) will stay in ... wait for it ... the center? ;-) |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the resize event is triggered, the original center was lost.
This issue is significant when the map is renders outside visible dom with zero height and width.
When placed into the visible dom, the resize is triggered correctly. With this change the center will persist. (Without this fix the old center is the top left corner)