Add ne and sw to bounds object#287
Conversation
|
Hi thank you, fully agree. Will check PR later today or tomorrow. |
|
All is fine, may be add ability to use NE SW (if NW SE is not provided) to documented fitBounds ? |
|
@istarkov It's make sense, what do you think about such approach:
|
|
Super! |
|
@istarkov cool, i'll push changes tomorrow morning |
|
Thank you! |
|
@istarkov hm, I thought a little bit about it today, and i don't really like that we're passing NE and SW to Also i think will can add some helpers like |
|
Agree that newBounds must have all corners, |
|
@istarkov done! |
src/utils/utils.js
Outdated
| }; | ||
| } | ||
|
|
||
| const exports = { |
There was a problem hiding this comment.
May be we will remove const exports = and all that this below, as it was time when export default { blabla } was the same as export const blabla
Having that it was deprecated in babel there is no need in exports object at all.
There was a problem hiding this comment.
Oh, that part seemed strange to me) Sure.
|
Super, all that my now will gone ;-) Thank you a lot!!!! |
|
At npm [email protected] |
|
Cool, glad that i helped 😉 |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Hi, thanks for the great library it serving to me faithfully not first time.
I found small problem with bounds object, most geo tools expect to receive data with NE and SW, instead of NW and SE. So i thought it will be cool if bounds object will contain all corners.