Do a proper check for object equality#440
Closed
rmacqueen wants to merge 1 commit intogoogle-map-react:masterfrom
Closed
Do a proper check for object equality#440rmacqueen wants to merge 1 commit intogoogle-map-react:masterfrom
rmacqueen wants to merge 1 commit intogoogle-map-react:masterfrom
Conversation
Previously we were just using a simple '==' to check if new defaultCenter was equal to old defaultCenter. However, defaultCenter is an object, and therefore '==' will always return false unless they reference the same object in memory. Instead we should do a proper comparison of the properties of the object.
itsmichaeldiego
requested changes
Dec 20, 2017
Member
itsmichaeldiego
left a comment
There was a problem hiding this comment.
Please fix travis errors here
| @@ -0,0 +1,25 @@ | |||
| export default function areObjectsEqual(a, b) { | |||
| // Create arrays of property names | |||
| var aProps = Object.getOwnPropertyNames(a); | |||
Member
There was a problem hiding this comment.
Lets use const or let instead of var.
Member
|
@rmacqueen As you did not answer I handled this using facebook's |
Author
|
@itsmichaeldiego oops, sorry didn't see this. What you did works though. Thanks! |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously we were just using a simple '==' to check if
new defaultCenter was equal to old defaultCenter. However,
defaultCenter is an object, and therefore '==' will always
return false unless they reference the same object in memory.
Instead we should do a proper comparison of the properties
of the object.