fix error about fromLatLngToDivPixel#517
Merged
itsmichaeldiego merged 2 commits intogoogle-map-react:masterfrom Feb 23, 2018
Merged
fix error about fromLatLngToDivPixel#517itsmichaeldiego merged 2 commits intogoogle-map-react:masterfrom
itsmichaeldiego merged 2 commits intogoogle-map-react:masterfrom
Conversation
fix "Cannot read property 'fromLatLngToDivPixel' of undefined" google-map-react#257
|
+1 |
1 similar comment
|
+1 |
|
+1, same error happening in production |
Member
itsmichaeldiego
left a comment
There was a problem hiding this comment.
I like this change but we need to keep in mind that there are some binding events under your return; that might get broken, so we should skip only the code that relates to div or overlay
Contributor
Author
|
@itsmichaeldiego I addressed your point. please review it! |
Member
|
@fmy @loris @Stosiu @jeremymarc Merged and published in version |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix "Cannot read property 'fromLatLngToDivPixel' of undefined" #257
In my production, errors occurred in the
idleevent handler, not in thedraw()function.I can not find the condition, but I can reproduce this error in local env.
It looks like below.