Use React 16 portal to render map overlay#643
Use React 16 portal to render map overlay#643itsmichaeldiego merged 2 commits intogoogle-map-react:masterfrom
Conversation
This allows the new context API to propagate context properly.
|
Done. |
|
This change breaks the component when used with React versions prior to 16. |
|
This should have been part of a major release then it would have been fine. So 1.0.6 is not broken but 1.0.7 is broken. (Complains about |
This reverts commit b121bb6.
|
@stuartherring @abumusamq Sorry for the inconvenience! This was totally my bad, I just fixed this and released in @clayne11 do you mind opening the PR again? We will add this to the next major release. Or, I think there should be a way to identify if the user has React 16 or not and use createPortal if so, but that would be a bit more tricky. |
|
No problem I can do that. Are you planning to cut a new major release with this soon? React 16 has been out for a year now (released Sept 26, 2017) so I think it's about time to move forward. |
|
@clayne11 Yes, we would like to do that soon but lately it has been only me taking care of the library, any help would be accepted lovely xD. |
* 'master' of github.com:google-map-react/google-map-react: Bump to 1.1.1 (google-map-react#680) Revert "Added feature: update heat map on data change + fix linting" (google-map-react#679) Bump version to 1.1.0 (google-map-react#671) Added feature: update heat map on data change + fix linting (google-map-react#593) Pass map instance to onDrag handler (google-map-react#656) add math abs to avoid negative values when calculating zoom (google-map-react#655) Bump version to 1.0.9 (google-map-react#651) Custom div style options (google-map-react#634) Bump version to 1.0.8 (google-map-react#646) Revert 643 fix/map context (google-map-react#645) Bump version to 1.0.7 (google-map-react#644) Add passive scroll (google-map-react#631) Use React 16 portal to render map overlay (google-map-react#643) Fix old examples links and add one to new examples (google-map-react#633) Bump version to 1.0.6 (google-map-react#621) Add prop `onTilesLoaded` (google-map-react#615) Fix typo, and call fromContainerPixelToLatLng() as you would expect. (google-map-react#620) Update API.md (google-map-react#611) Upgrade version to 1.0.5 (google-map-react#607) Remove marker jiggle. (google-map-react#603)
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This allows the new context API to propagate context properly.
Fixes #642.