feat: use @googlemaps/js-api-loader#942
Closed
jpoehnelt wants to merge 2 commits intogoogle-map-react:masterfrom
jpoehnelt:feat/js-api-loader
Closed
feat: use @googlemaps/js-api-loader#942jpoehnelt wants to merge 2 commits intogoogle-map-react:masterfrom jpoehnelt:feat/js-api-loader
jpoehnelt wants to merge 2 commits intogoogle-map-react:masterfrom
jpoehnelt:feat/js-api-loader
Conversation
Member
itsmichaeldiego
left a comment
There was a problem hiding this comment.
Hey @jpoehnelt, this is great!! Thanks! I have two comments here:
- Will using the loader, fix the problem with chinese URL? #708
- We're deprecating
heatmapLibrary, could we add something similar to what @aviyadeveloper's did here https://github.com/google-map-react/google-map-react/pull/934/files#diff-9a6a99e7dbcf49926535aa0d9547c3a0R62-R69 ?
Kind regards and thank you!!!
Contributor
Author
|
| const BASE_URL = 'https://maps'; | ||
| const DEFAULT_URL = `${BASE_URL}.googleapis.com`; | ||
| const API_PATH = '/maps/api/js?callback=_$_google_map_initialize_$_'; | ||
| const { Loader } = require('@googlemaps/js-api-loader'); |
Member
There was a problem hiding this comment.
Could we do import { Loader } from '@googlemaps/js-api-loader'; instead?
Member
|
@jpoehnelt Hey! I created a new PR with parts of your PR and some fixes, here it is #946, I kindly ask you if you can review it and let me know if its okey! Thanks. |
Member
|
@jpoehnelt Merged in #946 and Released in version |
This was referenced Sep 22, 2020
| return loadPromise_; | ||
| if (!bootstrapURLKeys.libraries) { | ||
| bootstrapURLKeys.libraries = []; | ||
| } |
Member
There was a problem hiding this comment.
@jpoehnelt Hey! Just wondering, why did we remove this line? I think this its causing this issue #954
This was referenced Oct 3, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use @googlemaps/js-api-loader to dynamically load the Google Maps API.
also fixes #922