Skip to content

Convert all Compute deserialized enum types to StringEnumValue#2136

Merged
tcoffee-google merged 2 commits intogoogleapis:masterfrom
tcoffee-google:string_enum_compute
Jun 14, 2017
Merged

Convert all Compute deserialized enum types to StringEnumValue#2136
tcoffee-google merged 2 commits intogoogleapis:masterfrom
tcoffee-google:string_enum_compute

Conversation

@tcoffee-google
Copy link
Copy Markdown
Contributor

Addresses #1944.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 9, 2017
@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.01%) to 81.205% when pulling a5550f5 on tcoffee-google:string_enum_compute into ae640b7 on GoogleCloudPlatform:master.

@tcoffee-google
Copy link
Copy Markdown
Contributor Author

For reference in case of future maintenance, the conversions here were done according to the semi-automated procedure described in #2128 (comment).

Copy link
Copy Markdown
Contributor

@shinfan shinfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after tests pass (there maybe some javadoc issues which caused the tests to fail)

@coveralls
Copy link
Copy Markdown

Coverage Status

Changes Unknown when pulling 77571ad on tcoffee-google:string_enum_compute into ** on GoogleCloudPlatform:master**.

@tcoffee-google tcoffee-google merged commit 357e1cc into googleapis:master Jun 14, 2017
@tcoffee-google tcoffee-google deleted the string_enum_compute branch June 14, 2017 13:58
chingor13 pushed a commit that referenced this pull request Feb 20, 2026
…-info-reports-plugin to v3.4.5 (#2136)

* build(deps): update dependency org.apache.maven.plugins:maven-project-info-reports-plugin to v3.4.5

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
suztomo pushed a commit to suztomo/google-cloud-java that referenced this pull request Mar 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants