remove tests from SubscriberTest#2618
Merged
pongad merged 1 commit intogoogleapis:masterfrom Nov 13, 2017
pongad:rm-sub-test
Merged
remove tests from SubscriberTest#2618pongad merged 1 commit intogoogleapis:masterfrom pongad:rm-sub-test
pongad merged 1 commit intogoogleapis:masterfrom
pongad:rm-sub-test
Conversation
These tests are moved, in simpler forms, to MessageDispatcherTest and ITPubSubTest. Eventually, we should test streaming reconnection logic independently and remove SubscriberTest altogether.
Contributor
Author
mdietz94
approved these changes
Nov 13, 2017
chingor13
pushed a commit
that referenced
this pull request
Feb 20, 2026
…-info-reports-plugin to v3.7.0 (#2618)
chingor13
pushed a commit
that referenced
this pull request
Mar 24, 2026
This is a temporarily change for lts., will revert when Beam is released. Set [`enabled to false](https://docs.renovatebot.com/configuration-options/#enabled) to disable Renovate for these two grpc and guava. currently grpc version is 1.62.2 (updated in [pr](https://github.com/googleapis/sdk-platform-java/pull/2506/files)), guava is 33.1.0-jre (updated in [pr](https://github.com/googleapis/sdk-platform-java/pull/2574/files))
chingor13
pushed a commit
that referenced
this pull request
Mar 24, 2026
Same as #2618, will revert when Beam is released. current version is v3.25.3 updated in googleapis/sdk-platform-java#2491
chingor13
pushed a commit
that referenced
this pull request
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These tests are moved, in simpler forms, to MessageDispatcherTest
and ITPubSubTest.
Eventually, we should test streaming reconnection logic independently
and remove SubscriberTest altogether.