Skip to content

Remove bigtableadmin artifact#4533

Merged
igorbernstein2 merged 4 commits intogoogleapis:masterfrom
igorbernstein2:remove-bigtable
Feb 22, 2019
Merged

Remove bigtableadmin artifact#4533
igorbernstein2 merged 4 commits intogoogleapis:masterfrom
igorbernstein2:remove-bigtable

Conversation

@igorbernstein2
Copy link
Copy Markdown
Contributor

@igorbernstein2 igorbernstein2 commented Feb 21, 2019 •
edited
Loading

Removes the google-bigtable-admin artifact (it was merged into the main bigtable artifact). Kokoro configs have been updated to stop referencing this artifact.

@igorbernstein2 igorbernstein2 added do not merge Indicates a pull request not ready for merge, due to either quality or timing. api: bigtable Issues related to the Bigtable API. labels Feb 21, 2019
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 21, 2019
@igorbernstein2 igorbernstein2 changed the title WIP: Remove bigtableadmin artifact Remove bigtableadmin artifact Feb 21, 2019
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 21, 2019 •
edited
Loading

Codecov Report

Merging #4533 into master will decrease coverage by 0.63%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #4533      +/-   ##
============================================
- Coverage     49.15%   48.52%   -0.64%     
+ Complexity    21940    20743    -1197     
============================================
  Files          2077     2076       -1     
  Lines        207215   203106    -4109     
  Branches      24108    23302     -806     
============================================
- Hits         101861    98556    -3305     
+ Misses        97180    96474     -706     
+ Partials       8174     8076      -98
Impacted Files Coverage Δ Complexity Δ
...bigtable/admin/v2/BigtableInstanceAdminClient.java 96.95% <ø> (-0.17%) 43 <0> (-3)
...ud/bigtable/admin/v2/BigtableTableAdminClient.java 78.57% <ø> (-0.43%) 23 <0> (-5)
...in/java/com/google/cloud/storage/StorageBatch.java 88% <0%> (-4%) 13% <0%> (ø)
...m/google/cloud/vision/v1/ImageAnnotatorClient.java 47.05% <0%> (-2.95%) 9% <0%> (-2%)
...e/cloud/vision/v1p3beta1/ImageAnnotatorClient.java 47.05% <0%> (-2.95%) 9% <0%> (-2%)
...e/cloud/vision/v1p2beta1/ImageAnnotatorClient.java 47.05% <0%> (-2.95%) 9% <0%> (-2%)
.../java/com/google/cloud/speech/v1/SpeechClient.java 48.57% <0%> (-2.78%) 10% <0%> (-2%)
...om/google/cloud/speech/v1p1beta1/SpeechClient.java 48.57% <0%> (-2.78%) 10% <0%> (-2%)
...ogle/cloud/texttospeech/v1/TextToSpeechClient.java 55.88% <0%> (-2.46%) 9% <0%> (-2%)
...cloud/texttospeech/v1beta1/TextToSpeechClient.java 55.88% <0%> (-2.46%) 9% <0%> (-2%)
... and 486 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ee8aa1...04c5ad3. Read the comment docs.

@igorbernstein2 igorbernstein2 removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Feb 21, 2019
@igorbernstein2 igorbernstein2 marked this pull request as ready for review February 21, 2019 19:51
@igorbernstein2 igorbernstein2 requested a review from a team February 21, 2019 19:51
@kolea2
Copy link
Copy Markdown
Contributor

kolea2 commented Feb 21, 2019

Just to confirm as it's a little hard to see in the diffs, does this PR remove the entire bigtable-admin module?

kolea2
kolea2 reviewed Feb 21, 2019
View reviewed changes
@igorbernstein2
Copy link
Copy Markdown
Contributor Author

igorbernstein2 commented Feb 21, 2019

Yep, the entire module is removed, you can see how the tree looks here:
https://github.com/igorbernstein2/google-cloud-java/tree/remove-bigtable/google-cloud-clients

@sduskis
Copy link
Copy Markdown
Contributor

sduskis commented Feb 22, 2019

@igorbernstein2, can you please resolve the conflicts?

@igorbernstein2
Merge remote-tracking branch 'origin/master' into remove-bigtable
92e1e50 
# Conflicts:
#	google-cloud-bom/pom.xml
#	google-cloud-clients/google-cloud-bigtable-admin/pom.xml
#	google-cloud-testing/google-cloud-bigtable-emulator/README.md
#	versions.txt
@igorbernstein2
fix merge
04c5ad3
@igorbernstein2
Copy link
Copy Markdown
Contributor Author

igorbernstein2 commented Feb 22, 2019

Fixed, the test failure is unrelated

@igorbernstein2 igorbernstein2 merged commit ed3a0c8 into googleapis:master Feb 22, 2019
@igorbernstein2 igorbernstein2 deleted the remove-bigtable branch February 22, 2019 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@kolea2 kolea2 kolea2 left review comments

@sduskis sduskis sduskis approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: bigtable Issues related to the Bigtable API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@igorbernstein2 @kolea2 @sduskis @googlebot