honor executor provider passed via EnhancedBigtableStubSettings in the constructor#6323
Merged
igorbernstein2 merged 1 commit intogoogleapis:masterfrom Sep 24, 2019
mackenziestarr:mstarr/bigtable-fix-exec-provider
Merged
honor executor provider passed via EnhancedBigtableStubSettings in the constructor#6323igorbernstein2 merged 1 commit intogoogleapis:masterfrom mackenziestarr:mstarr/bigtable-fix-exec-provider
igorbernstein2 merged 1 commit intogoogleapis:masterfrom
mackenziestarr:mstarr/bigtable-fix-exec-provider
Conversation
igorbernstein2
approved these changes
Sep 24, 2019
Contributor
igorbernstein2
left a comment
There was a problem hiding this comment.
Thanks for catching this.
Author
|
Thanks @igorbernstein2 for the quick merge! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am integrating this client into an existing Netty application and I was surprised to see that only 4 executor threads are created. I attempted to increase the thread pool size via
stubSettings.setExecutorProviderbut my settings are ignored.Fixes #6322