Skip to content

Logging - Logback : Reference libraries-bom in docs#6760

Merged
elharo merged 1 commit intogoogleapis:masterfrom
athakor:cloud-logging-logback-6668
Nov 13, 2019
Merged

Logging - Logback : Reference libraries-bom in docs#6760
elharo merged 1 commit intogoogleapis:masterfrom
athakor:cloud-logging-logback-6668

Conversation

@athakor
Copy link
Copy Markdown
Contributor

@athakor athakor commented Nov 13, 2019

towards #6668

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 13, 2019
@athakor athakor requested review from chingor13 and elharo November 13, 2019 08:44
@codecov
Copy link
Copy Markdown

codecov bot commented Nov 13, 2019

Codecov Report

Merging #6760 into master will decrease coverage by 0.36%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #6760      +/-   ##
============================================
- Coverage     46.37%   46.01%   -0.37%     
+ Complexity    28040    26539    -1501     
============================================
  Files          2614     2614              
  Lines        288317   282913    -5404     
  Branches      33805    33608     -197     
============================================
- Hits         133715   130189    -3526     
+ Misses       144336   143432     -904     
+ Partials      10266     9292     -974
Impacted Files Coverage Δ Complexity Δ
...m/google/cloud/vision/v1/ImageAnnotatorClient.java 58.69% <0%> (-3.31%) 15% <0%> (-4%)
...e/cloud/vision/v1p4beta1/ImageAnnotatorClient.java 58.69% <0%> (-3.31%) 15% <0%> (-4%)
...e/cloud/vision/v1p3beta1/ImageAnnotatorClient.java 47.05% <0%> (-2.95%) 9% <0%> (-2%)
...e/cloud/vision/v1p2beta1/ImageAnnotatorClient.java 47.05% <0%> (-2.95%) 9% <0%> (-2%)
...d/webrisk/v1beta1/WebRiskServiceV1Beta1Client.java 63.41% <0%> (-2.5%) 12% <0%> (-3%)
...ogle/cloud/texttospeech/v1/TextToSpeechClient.java 55.88% <0%> (-2.46%) 9% <0%> (-2%)
...cloud/texttospeech/v1beta1/TextToSpeechClient.java 55.88% <0%> (-2.46%) 9% <0%> (-2%)
...oogle/cloud/language/v1/LanguageServiceClient.java 79.16% <0%> (-2.32%) 26% <0%> (-9%)
...e/cloud/vision/v1p1beta1/ImageAnnotatorClient.java 42.3% <0%> (-2.14%) 6% <0%> (-1%)
...aming/v1alpha/GameServerClustersServiceClient.java 65.93% <0%> (-2.11%) 21% <0%> (-1%)
... and 640 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b47858f...e9e45b2. Read the comment docs.

@athakor athakor added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 13, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 13, 2019
@elharo elharo merged commit 319750d into googleapis:master Nov 13, 2019
@chingor13 chingor13 mentioned this pull request Nov 13, 2019
Merged
chingor13 pushed a commit that referenced this pull request Jan 6, 2026
@athakor @elharo
docs: reference libraries-bom in docs (#6760)
b69b719
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chingor13 chingor13 Awaiting requested review from chingor13

1 more reviewer

@elharo elharo elharo approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@athakor @elharo @googlebot @yoshi-kokoro