Skip to content

Release spanner 1.5.0#5925

Merged
theacodes merged 2 commits intomasterfrom
release-spanner-1.5.0
Sep 11, 2018
Merged

Release spanner 1.5.0#5925
theacodes merged 2 commits intomasterfrom
release-spanner-1.5.0

Conversation

@theacodes
Copy link
Contributor

@theacodes theacodes commented Sep 11, 2018

This pull request was generated using releasetool.

@theacodes theacodes requested a review from tseaver as a code owner September 11, 2018 18:22
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 11, 2018
@googlebot
Copy link

googlebot commented Sep 11, 2018

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

@googlebot googlebot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Sep 11, 2018
tseaver
tseaver reviewed Sep 11, 2018
View reviewed changes
Copy link
Contributor

@tseaver tseaver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that we have made grpcio-gcp an unconditional dependency, we should remove the extra nox environments for it.

@tseaver tseaver added packaging api: spanner Issues related to the Spanner API. labels Sep 11, 2018
@tseaver tseaver mentioned this pull request Sep 11, 2018
Merged
@tseaver
Copy link
Contributor

tseaver commented Sep 11, 2018

#5927 drops the extra testing. I guess it doesn't need to block the release.

tseaver added a commit that referenced this pull request Sep 11, 2018
@tseaver
Drop separate testing for grpcio-gcp. (#5927)
406e78f 
We made it an unconditional dependency.

See #5925.
@theacodes theacodes added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Sep 11, 2018
@googlebot
Copy link

googlebot commented Sep 11, 2018

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

@theacodes theacodes merged commit c0e996d into master Sep 11, 2018
@theacodes theacodes deleted the release-spanner-1.5.0 branch September 11, 2018 19:07
@theacodes
Copy link
Contributor Author

theacodes commented Sep 11, 2018

Release is at https://github.com/GoogleCloudPlatform/google-cloud-python/releases/tag/spanner-1.5.0

parthea pushed a commit that referenced this pull request Mar 9, 2026
@tseaver
Drop separate testing for grpcio-gcp. (#5927)
9042c21 
We made it an unconditional dependency.

See #5925.
parthea pushed a commit that referenced this pull request Mar 9, 2026
@theacodes
Release spanner 1.5.0 (#5925)
a686931
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@tseaver tseaver tseaver approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: spanner Issues related to the Spanner API. cla: yes This human has signed the Contributor License Agreement. packaging

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@theacodes @googlebot @tseaver