Skip to content

Add user_agent property to ClientInfo#7799

Merged
tswast merged 2 commits intogoogleapis:masterfrom
tswast:b116069533-user-agent-prefix
Apr 29, 2019
Merged

Add user_agent property to ClientInfo#7799
tswast merged 2 commits intogoogleapis:masterfrom
tswast:b116069533-user-agent-prefix

Conversation

@tswast
Copy link
Contributor

@tswast tswast commented Apr 24, 2019

This provides a way for partners to define a prefix identifying their
tool or application, as required by many cloud partnership agreements.

@tswast tswast requested review from busunkim96 and crwilcox April 24, 2019 20:25
@tswast tswast requested a review from theacodes as a code owner April 24, 2019 20:25
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 24, 2019
@busunkim96
Copy link
Contributor

busunkim96 commented Apr 24, 2019

A pytype check is failing. (I don't think it's related to this change?)

[3/26] check google.api_core.datetime_helpers
FAILED: /tmpfs/src/github/google-cloud-python/api_core/pytype_output/pyi/google/api_core/datetime_helpers.pyi
pytype-single --imports_info /tmpfs/src/github/google-cloud-python/api_core/pytype_output/imports/google.api_core.datetime_helpers.imports --module-name google.api_core.datetime_helpers -V 3.6 -o /tmpfs/src/github/google-cloud-python/api_core/pytype_output/pyi/google/api_core/datetime_helpers.pyi --analyze-annotated --nofail --quick /tmpfs/src/github/google-cloud-python/api_core/google/api_core/datetime_helpers.py
File "/tmpfs/src/github/google-cloud-python/api_core/google/api_core/datetime_helpers.py", line 23, in <module>: Couldn't import pyi for 'google.protobuf.timestamp_pb2' [pyi-error]
  Can't find pyi for 'google.protobuf.descriptor_pb2.FieldOptions', referenced from 'google.protobuf.descriptor_pb2'
For more details, see https://google.github.io/pytype/errors.html#pyi-error.

@rchen152 Do you have any insight here?

@rchen152
Copy link
Contributor

rchen152 commented Apr 25, 2019

It looks like you've been bitten by google/pytype#150 - pytype has trouble loading some third party pyi files, including the google.protobuf ones, it seems.

The easiest workaround is to add disable = pyi-error to the pytype section of setup.cfg.

tswast added 2 commits April 25, 2019 09:55
@tswast
Add user_agent property to ClientInfo
879af8c 
This provides a way for partners to define a prefix identifying their
tool or application, as required by many cloud partnership agreements.
@tswast
Workaround for pytype pyi error with nested class.
2a24250
@tswast tswast force-pushed the b116069533-user-agent-prefix branch from 2f1f0f1 to 2a24250 Compare April 25, 2019 17:05
@tswast tswast mentioned this pull request Apr 25, 2019
Merged
@tswast tswast merged commit a2c1f6c into googleapis:master Apr 29, 2019
@tswast tswast deleted the b116069533-user-agent-prefix branch April 29, 2019 17:04
parthea pushed a commit that referenced this pull request Nov 24, 2025
@tswast
Add user_agent property to ClientInfo (#7799)
8f4d6ac 
* Add `user_agent` property to `ClientInfo`

This provides a way for partners to define a prefix identifying their
tool or application, as required by many cloud partnership agreements.

* Workaround for pytype pyi error with nested class.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@busunkim96 busunkim96 Awaiting requested review from busunkim96

@theacodes theacodes Awaiting requested review from theacodes

2 more reviewers

@tseaver tseaver tseaver approved these changes

@crwilcox crwilcox crwilcox approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: core cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@tswast @busunkim96 @rchen152 @tseaver @crwilcox @googlebot