This repository was archived by the owner on Apr 7, 2026. It is now read-only.
docs(sample): relocate native image sample from old repo#1758
Merged
docs(sample): relocate native image sample from old repo#1758
Conversation
|
Warning: This pull request is touching the following templated files:
|
ansh0l
approved these changes
Mar 29, 2022
Contributor
ansh0l
left a comment
There was a problem hiding this comment.
LGTM.
Minor nit: I think since the parent folder is named samples, we should call this one as native-image instead of native-image-sample
…er into move-native-sample
Contributor
Author
|
Thank you @ansh0l! I've renamed this to |
Contributor
|
Closing since native image changes have been released with #1878 |
Contributor
Author
|
Rerunning because |
Contributor
Author
|
All checks are now green. |
ansh0l
reviewed
Jun 1, 2022
Contributor
ansh0l
left a comment
There was a problem hiding this comment.
At a quick glance, looks alright. Please take a full review with @rajatbhatta
| <dependency> | ||
| <groupId>com.google.cloud</groupId> | ||
| <artifactId>libraries-bom</artifactId> | ||
| <version>25.2.0</version> |
Contributor
There was a problem hiding this comment.
QQ> AFAIK, currently, we get automated PRs for cloud bom version bumps. Would now there be 2 such PRs (one for regular samples/pom.xml, another for samples/native-image/pom.xml), or would both end up coming into 1 PR?
Contributor
Author
There was a problem hiding this comment.
It would all be updated in a single PR. Here is an example: googleapis/java-pubsub#1132
rajatbhatta
reviewed
Jun 2, 2022
Co-authored-by: Rajat Bhatta <[email protected]>
The requested changes have been addressed so modifying this to a request comment after receiving an approval from @rajatbhatta
Contributor
Author
|
Thank you both for the review! |
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Jun 22, 2022
🤖 I have created a release *beep* *boop* --- ## [6.25.6](v6.25.5...v6.25.6) (2022-06-22) ### Bug Fixes * PostgreSQL parser should not treat \ as an escape char ([#1921](#1921)) ([260bbe3](260bbe3)), closes [#1920](#1920) ### Documentation * **sample:** relocate native image sample from old repo ([#1758](#1758)) ([ef187f4](ef187f4)) ### Dependencies * update dependency org.graalvm.buildtools:native-maven-plugin to v0.9.11 ([#1907](#1907)) ([01f8a07](01f8a07)) * update dependency org.graalvm.buildtools:native-maven-plugin to v0.9.12 ([#1918](#1918)) ([be8b50b](be8b50b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relocating Spanner sample from GoogleCloudPlatform/native-image-support-java.
This PR also adds an integration test that can be run as a native image.
Calling
mvn package -Pnative -DskipTestsbuilds the native image for the application and callingmvn test -Pnativeruns the test as a native image.For more information: https://graalvm.github.io/native-build-tools/latest/maven-plugin.html#configuration.
cc @ansh0l @meltsufin