This repository was archived by the owner on Apr 7, 2026. It is now read-only.
fix: update samples/snippets pom.xml configuration to avoid fat jar#2100
Merged
harshachinta merged 3 commits intogoogleapis:mainfrom Dec 5, 2022
Merged
fix: update samples/snippets pom.xml configuration to avoid fat jar#2100harshachinta merged 3 commits intogoogleapis:mainfrom
harshachinta merged 3 commits intogoogleapis:mainfrom
Conversation
Contributor
Author
|
@olavloite @rajatbhatta @ansh0l |
olavloite
approved these changes
Nov 30, 2022
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Dec 13, 2022
🤖 I have created a release *beep* *boop* --- ## [6.34.0](https://togithub.com/googleapis/java-spanner/compare/v6.33.0...v6.34.0) (2022-12-12) ### Features * Setting up 6.33.x branch ([#2184](https://togithub.com/googleapis/java-spanner/issues/2184)) ([e237a21](https://togithub.com/googleapis/java-spanner/commit/e237a213cf5cb5edc338ca4e5f8ad5dd0593d2d1)) ### Bug Fixes * Remove the statement of session number limits ([#1928](https://togithub.com/googleapis/java-spanner/issues/1928)) ([ddd0625](https://togithub.com/googleapis/java-spanner/commit/ddd062527674659ca2ea73e079bca4dee62ca67f)), closes [#1927](https://togithub.com/googleapis/java-spanner/issues/1927) * Update samples/snippets pom.xml configuration to avoid fat jar ([#2100](https://togithub.com/googleapis/java-spanner/issues/2100)) ([19058b4](https://togithub.com/googleapis/java-spanner/commit/19058b4cd324ce33e8dd52447bde2486c87d4754)) * Use a proper endpoint for DirectPath tests ([#2186](https://togithub.com/googleapis/java-spanner/issues/2186)) ([4d74a0d](https://togithub.com/googleapis/java-spanner/commit/4d74a0d8ae48e190c126ab4047b81cca117f4de1)) ### Dependencies * Update dependency org.graalvm.buildtools:junit-platform-native to v0.9.18 ([#2171](https://togithub.com/googleapis/java-spanner/issues/2171)) ([f348780](https://togithub.com/googleapis/java-spanner/commit/f3487805fe5f976596e94047c3796bc623eeae95)) * Update dependency org.graalvm.buildtools:native-maven-plugin to v0.9.18 ([#2145](https://togithub.com/googleapis/java-spanner/issues/2145)) ([dcdd2c3](https://togithub.com/googleapis/java-spanner/commit/dcdd2c3b684e38892fac0abbdf06081e9c7d83b2)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fix updates the build configuration of samples/snippets pom.xml by not creating a fat jar to avoid unexpected issues and code breaks in different environments and systems.
Existing Configuration:
spanner-google-cloud-samples-jar-with-dependencies.jar(fat jar) undertargetfolder.Updated Configuration:
spanner-google-cloud-samples.jar(not a fat jar) undertarget/spanner-snippetsfolder. The libraries are created in thelibfolder undertarget/spanner-snippets.