This repository was archived by the owner on Apr 7, 2026. It is now read-only.
feat: add support for new cloud client test framework in google-cloud-spanner-executor#2217
Merged
rajatbhatta merged 61 commits intogoogleapis:mainfrom Jan 10, 2023
gyang-google:spanner-executor
Merged
feat: add support for new cloud client test framework in google-cloud-spanner-executor#2217rajatbhatta merged 61 commits intogoogleapis:mainfrom gyang-google:spanner-executor
rajatbhatta merged 61 commits intogoogleapis:mainfrom
gyang-google:spanner-executor
Conversation
…or optimistic only)
Prepare new protos for existing executor features.
Commented out Batch txns and change stream for future support.
Prepare protos for change stream.
Fix partition token. Fix request index for batch read.
…issue. This is achieved by wrapping streamObserver into executionFlowContext and make all the calls synchronized.
…or optimistic only)
Prepare new protos for existing executor features.
Commented out Batch txns and change stream for future support.
Reformat code.
Add createUserInstanceConfig and deleteUserInstanceConfig. Fix instanceConfig conversion issue.
Fix replicas in createUserInstanceConfig.
Fix numeric key issue.
rajatbhatta
suggested changes
Jan 6, 2023
...ud-spanner-executor/src/main/java/com/google/cloud/executor/spanner/CloudClientExecutor.java
Outdated
Show resolved
Hide resolved
google-cloud-spanner-executor/src/main/java/com/google/cloud/executor/spanner/WorkerProxy.java
Outdated
Show resolved
Hide resolved
google-cloud-spanner-executor/src/main/java/com/google/cloud/executor/spanner/WorkerProxy.java
Outdated
Show resolved
Hide resolved
...ud-spanner-executor/src/main/java/com/google/cloud/executor/spanner/CloudClientExecutor.java
Outdated
Show resolved
Hide resolved
...ud-spanner-executor/src/main/java/com/google/cloud/executor/spanner/CloudClientExecutor.java
Show resolved
Hide resolved
...ud-spanner-executor/src/main/java/com/google/cloud/executor/spanner/CloudClientExecutor.java
Show resolved
Hide resolved
google-cloud-spanner-executor/src/main/java/com/google/cloud/executor/spanner/WorkerProxy.java
Outdated
Show resolved
Hide resolved
google-cloud-spanner-executor/src/main/java/com/google/cloud/executor/spanner/WorkerProxy.java
Outdated
Show resolved
Hide resolved
rajatbhatta
approved these changes
Jan 10, 2023
Contributor
rajatbhatta
left a comment
There was a problem hiding this comment.
Lgtm. Thank you for working on this, @gyang-google !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the initial commit for client-wise executor of cloud Java Spanner client. This feature enables the ability to test cloud Spanner clients through an universal testing protos, defined by proto-google-cloud-spanner-executor-v1.