This repository was archived by the owner on Apr 7, 2026. It is now read-only.
chore(spanner): code refactoring#3126
Closed
harshachinta wants to merge 2 commits intogoogleapis:mainfrom
Closed
Conversation
olavloite
previously approved these changes
May 27, 2024
| .setProjectId(options.getProjectId()) | ||
| .setInstanceId(options.getInstanceId()) | ||
| .setDatabaseName(options.getDatabaseName()) | ||
| .setDatabaseId( |
Collaborator
There was a problem hiding this comment.
nit: You can call options.getDatabaseId() instead of the separate options.getProjectId() etc. methods.
Collaborator
|
@harshachinta Is this something you still want to merge? Or should we close this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is to fix the refactoring comments in #3123