This repository was archived by the owner on Apr 7, 2026. It is now read-only.
test: removes flaky close result set test#888
Merged
thiagotnunes merged 1 commit intogoogleapis:masterfrom Feb 18, 2021
Merged
Conversation
This test was introduced in order to debug stuck transactions. The cause was unrelated though. The test here is flaky, because there is a race condition between setting the stream field in the AbstractResultSet and checking it in the close method. Since the result set is not intended to be thread safe, we will not be synchronizing this variable.
olavloite
approved these changes
Feb 18, 2021
Codecov Report
@@ Coverage Diff @@
## master #888 +/- ##
============================================
- Coverage 85.25% 85.19% -0.07%
+ Complexity 2624 2622 -2
============================================
Files 145 145
Lines 14262 14262
Branches 1378 1378
============================================
- Hits 12159 12150 -9
- Misses 1531 1537 +6
- Partials 572 575 +3
Continue to review full report at Codecov.
|
rajatbhatta
pushed a commit
to rajatbhatta/java-spanner
that referenced
this pull request
Nov 17, 2022
🤖 I have created a release *beep* *boop* --- ## [2.7.2](googleapis/java-spanner-jdbc@v2.7.1...v2.7.2) (2022-05-31) ### Dependencies * google-cloud-spanner-bom 6.25.5 ([googleapis#887](googleapis/java-spanner-jdbc#887)) ([2ec08bf](googleapis/java-spanner-jdbc@2ec08bf)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test was introduced in order to debug stuck transactions. The cause was unrelated though.
The test here is flaky, because there is a race condition between setting the stream field in the AbstractResultSet and checking it in the close method. Since the result set is not intended to be thread safe, we will not be synchronizing this variable.
More information can be seen in @olavloite 's investigation in: #869 (comment)
Fixes #869