Skip to content

docs(samples): read, import, batch_serve, batch_create features#1046

Merged
nayaknishant merged 39 commits intogoogleapis:mainfrom
nayaknishant:nn-fs-batch-import-read
Mar 8, 2022
Merged

docs(samples): read, import, batch_serve, batch_create features#1046
nayaknishant merged 39 commits intogoogleapis:mainfrom
nayaknishant:nn-fs-batch-import-read

Conversation

@nayaknishant
Copy link
Copy Markdown
Contributor

@nayaknishant nayaknishant commented Mar 2, 2022

Migrated remaining GAPIC featurestore samples to SDK.

nayaknishant and others added 30 commits January 26, 2022 16:30
)

* feat: SDK feature store samples (create/delete fs)

* feat: adding to conftest.py

* docs(samples): fixed testing

* docs(samples): fixed testing

* docs(samples): fixed testing

* docs(samples) added changes

* docs(samples): style issues

* Update samples/model-builder/create_featurestore_sample_test.py

Co-authored-by: Morgan Du <[email protected]>

* Update samples/model-builder/test_constants.py

Co-authored-by: Morgan Du <[email protected]>

* Update samples/model-builder/create_featurestore_sample_test.py

Co-authored-by: Morgan Du <[email protected]>

Co-authored-by: Morgan Du <[email protected]>
@nayaknishant nayaknishant requested review from a team and morgandu March 2, 2022 23:03
@nayaknishant nayaknishant requested a review from a team as a code owner March 2, 2022 23:03
@nayaknishant nayaknishant requested a review from parthea March 2, 2022 23:03
@snippet-bot
Copy link
Copy Markdown

snippet-bot bot commented Mar 2, 2022

Here is the summary of changes.

You are about to add 4 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Mar 2, 2022
Comment on lines +34 to +41
FEATURE_CONFIGS = {
"age": {"value_type": "INT64", "description": "User age"},
"gender": {"value_type": "STRING", "description": "User gender"},
"liked_genres": {
"value_type": "STRING_ARRAY",
"description": "An array of genres this user liked",
},
}
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
FEATURE_CONFIGS = {
"age": {"value_type": "INT64", "description": "User age"},
"gender": {"value_type": "STRING", "description": "User gender"},
"liked_genres": {
"value_type": "STRING_ARRAY",
"description": "An array of genres this user liked",
},
}
FEATURE_CONFIGS = {
"age": {
"value_type": "INT64",
"description": "User age"
},
"gender": {
"value_type": "STRING",
"description": "User gender"
},
"liked_genres": {
"value_type": "STRING_ARRAY",
"description": "An array of genres this user liked",
},
}

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@nayaknishant nayaknishant merged commit 80dd40d into googleapis:main Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants