This repository was archived by the owner on Apr 1, 2026. It is now read-only.
feat: Add deferred data uploading#1720
Merged
TrevorBergeron merged 12 commits intomainfrom May 22, 2025
Merged
Conversation
tswast
reviewed
May 15, 2025
Comment on lines
+549
to
+554
| if node.offsets_col is not None: | ||
| scan_list = scan_list.append( | ||
| bq_source.table.physical_schema[-1].name, | ||
| bigframes.dtypes.INT_DTYPE, | ||
| node.offsets_col, | ||
| ) |
Contributor
There was a problem hiding this comment.
What's the reason that offsets_col isn't in source_mapping, already? Could you add a comment explaining it?
Contributor
Author
There was a problem hiding this comment.
Its a bit clumsy due to offsets_col only really being a thing for the local node, so when we upload, we will set the final physical column to be those offsets, but then we just have to add to the end of the scan_list for the ReadTableNode. Added a comment to explain. Probably some room to respec the leaf nodes for a bit more of a 1:1 mapping.
tswast
reviewed
May 20, 2025
tswast
approved these changes
May 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕