Skip to content
This repository was archived by the owner on Apr 1, 2026. It is now read-only.

tests: fix failing e2e tests#726

Merged
tswast merged 3 commits intomainfrom
tswast-e2e
May 29, 2024
Merged

tests: fix failing e2e tests#726
tswast merged 3 commits intomainfrom
tswast-e2e

Conversation

@tswast
Copy link
Copy Markdown
Contributor

@tswast tswast commented May 28, 2024

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@tswast tswast requested review from a team and ashleyxuu May 28, 2024 22:07
@product-auto-label product-auto-label bot added the size: s Pull request size is small. label May 28, 2024
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. label May 28, 2024
tswast
tswast commented May 28, 2024
View reviewed changes
tests/system/large/test_remote_function.py Outdated
@@ -1432,9 +1433,7 @@ def square_num(x):


def test_remote_function_via_session_vpc_invalid(session):
Copy link
Copy Markdown
Contributor Author

@tswast tswast May 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: Might be better to replace this test with a unit test where we verify that we're actually sending VPC info in the relevant requests.

Copy link
Copy Markdown
Contributor Author

@tswast tswast May 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed this test, as it's redundant with the check here:

python-bigquery-dataframes/tests/system/large/test_remote_function.py

Line 1426 in 72e9583

assert gcf.service_config.vpc_connector == gcf_vpc_connector

@tswast tswast enabled auto-merge (squash) May 29, 2024 15:03
@tswast tswast disabled auto-merge May 29, 2024 15:32
@tswast tswast enabled auto-merge (squash) May 29, 2024 15:35
@tswast
Copy link
Copy Markdown
Contributor Author

tswast commented May 29, 2024

e2e nox session is now succeeding. Regarding the doctest failures, it looks like maybe we aren't correctly installing from source? The failures are for TypeError: remote_function() missing 2 required positional arguments: 'input_types' and 'output_type' which should both be optional arguments as of #717

Filed internal issue 343447415 to investigate.

=========================== short test summary info ============================
FAILED third_party/bigframes_vendored/pandas/core/frame.py::frame.DataFrame.map
FAILED third_party/bigframes_vendored/pandas/core/frame.py::frame.DataFrame.apply
FAILED third_party/bigframes_vendored/pandas/core/series.py::series.Series.mask
FAILED third_party/bigframes_vendored/pandas/core/series.py::series.Series.apply
FAILED third_party/bigframes_vendored/pandas/core/series.py::series.Series.map
FAILED bigframes/dataframe.py::bigframes.dataframe.DataFrame.applymap
FAILED bigframes/dataframe.py::bigframes.dataframe.DataFrame.map
7 failed, 455 passed, 89 warnings in 491.39s (0:08:11)
nox > Command py.test --quiet -n=20 --timeout=900 --durations=20 --junitxml=doctest_3.12_sponge_log.xml --cov=bigframes --cov=bigframes --cov-append --cov-config=.coveragerc --cov-report=term-missing --cov-fail-under=0 --doctest-modules third_party bigframes failed with exit code 1
nox > Session doctest failed.
nox > Ran multiple sessions:
nox > * e2e: success
nox > * doctest: failed

@tswast tswast merged commit 804e9e3 into main May 29, 2024
@tswast tswast deleted the tswast-e2e branch May 29, 2024 15:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ashleyxuu ashleyxuu Awaiting requested review from ashleyxuu

1 more reviewer

@TrevorBergeron TrevorBergeron TrevorBergeron approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@chelsea-lin chelsea-lin

Labels

api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: s Pull request size is small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tswast @TrevorBergeron @chelsea-lin