This repository was archived by the owner on Mar 16, 2026. It is now read-only.
fix: use project_id property from service account credentials#120
Merged
tswast merged 3 commits intogoogleapis:masterfrom Apr 12, 2021
Merged
fix: use project_id property from service account credentials#120tswast merged 3 commits intogoogleapis:masterfrom
project_id property from service account credentials#120tswast merged 3 commits intogoogleapis:masterfrom
Conversation
shollyman
approved these changes
Apr 12, 2021
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Apr 12, 2021
🤖 I have created a release \*beep\* \*boop\* --- ### [0.6.1](https://www.github.com/googleapis/python-bigquery-sqlalchemy/compare/v0.6.0...v0.6.1) (2021-04-12) ### Bug Fixes * use `project_id` property from service account credentials ([#120](https://www.github.com/googleapis/python-bigquery-sqlalchemy/issues/120)) ([ab2051d](https://www.github.com/googleapis/python-bigquery-sqlalchemy/commit/ab2051de3097adb68503c01a87f9a91092711d2a)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
jimfulton
reviewed
Apr 13, 2021
Contributor
jimfulton
left a comment
There was a problem hiding this comment.
Why a system rather than a unit test?
| @pytest.fixture(scope="session") | ||
| def module_under_test(): | ||
| from pybigquery import _helpers | ||
|
|
Contributor
There was a problem hiding this comment.
What's he purpose of this?
Why not just refer to _helpers? Do we think the name is likely to change?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds system tests for greater assurance that these code paths function as expected.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #118 🦕