Skip to content
This repository was archived by the owner on Feb 26, 2026. It is now read-only.

fix: unintended exception omittion#736

Merged
daniel-sanche merged 5 commits intogoogleapis:mainfrom
shkumagai:fix/unintended-exception-omittion
Sep 25, 2023
Merged

fix: unintended exception omittion#736
daniel-sanche merged 5 commits intogoogleapis:mainfrom
shkumagai:fix/unintended-exception-omittion

Conversation

@shkumagai
Copy link
Contributor

@shkumagai shkumagai commented Mar 30, 2023 •
edited
Loading

As I wrote in #735, StructuredLogHander removes exception info from the record object directly to omit traceback in a structured log message (it was fixed in #394).
This affects any log handlers that will be called later than StructuredLogHander.

This PR changes implementation to omit traceback in a log message.

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #735 🦕

@shkumagai shkumagai requested a review from a team as a code owner March 30, 2023 05:24
@shkumagai shkumagai requested a review from a team March 30, 2023 05:24
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: logging Issues related to the googleapis/python-logging API. labels Mar 30, 2023
@shkumagai shkumagai force-pushed the fix/unintended-exception-omittion branch from f9a54b2 to 6248e5d Compare April 24, 2023 23:21
@product-auto-label product-auto-label bot added the stale: old Pull request is old and needs attention. label Apr 29, 2023
@product-auto-label product-auto-label bot added stale: extraold Pull request is critically old and needs prioritization. and removed stale: old Pull request is old and needs attention. labels May 29, 2023
@parthea parthea added kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Aug 9, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 9, 2023
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Aug 9, 2023
@daniel-sanche daniel-sanche added the kokoro:run Add this label to force Kokoro to re-run the tests. label Sep 25, 2023
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. labels Sep 25, 2023
@daniel-sanche daniel-sanche added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 25, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 25, 2023
@daniel-sanche
Copy link
Contributor

daniel-sanche commented Sep 25, 2023

thanks for putting this together!

@daniel-sanche daniel-sanche merged commit 022dc54 into googleapis:main Sep 25, 2023
@release-please release-please bot mentioned this pull request Sep 25, 2023
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@daniel-sanche daniel-sanche daniel-sanche approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@daniel-sanche daniel-sanche

Labels

api: logging Issues related to the googleapis/python-logging API. size: s Pull request size is small. stale: extraold Pull request is critically old and needs prioritization.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Unintended traceback omittion

5 participants

@shkumagai @daniel-sanche @parthea @yoshi-kokoro @meredithslota