This repository was archived by the owner on Feb 26, 2026. It is now read-only.
fix: exception log message format#394
Merged
daniel-sanche merged 13 commits intomainfrom Sep 14, 2021
Merged
Conversation
minherz
approved these changes
Sep 12, 2021
Contributor
minherz
left a comment
There was a problem hiding this comment.
From the change list it is hard to understand the justification for duplicating the record before formatting. Since the expected use of the record is for logging only, full duplication of the object seems unnecessary.
Comment on lines
+64
to
+65
| record = copy(record) | ||
| record.exc_info = None |
Contributor
There was a problem hiding this comment.
since the record object is used for logging, what is a reason to create a full copy of the record object? why not to reset the .exc_info on the argument directly?
Otherwise, consider to use a distinct variable for the copy instead of "reusing" record.
Contributor
Author
There was a problem hiding this comment.
I was doing some experimenting, but ended up modifying the record object directly
…ng into parse-exceptions
…ng into parse-exceptions
9d15a80 to
c8e3ed0
Compare
c8e3ed0 to
18b8211
Compare
This was referenced Mar 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, logging an exception with
logger.exceptionwould append traceback information as part of the log message, making it hard to read. This PR removes the extra exception info from the LogEntryFixes #382 🦕