This repository was archived by the owner on Mar 9, 2026. It is now read-only.
fix: shutdown error on streaming pull callback error#40
Merged
pradn merged 2 commits intogoogleapis:masterfrom Feb 28, 2020
Merged
fix: shutdown error on streaming pull callback error#40pradn merged 2 commits intogoogleapis:masterfrom
pradn merged 2 commits intogoogleapis:masterfrom
Conversation
pradn
suggested changes
Feb 28, 2020
plamut
commented
Feb 28, 2020
pradn
approved these changes
Feb 28, 2020
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Feb 28, 2020
🤖 I have created a release \*beep\* \*boop\* --- ### [1.3.1](https://www.github.com/googleapis/python-pubsub/compare/v1.3.0...v1.3.1) (2020-02-28) ### Bug Fixes * shutdown error on streaming pull callback error ([#40](https://www.github.com/googleapis/python-pubsub/issues/40)) ([552539e](https://www.github.com/googleapis/python-pubsub/commit/552539e7beb30833c39dd29bfcb0183a07895f97)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #39.
This PR fixes an error that can happen if cancelling a streaming pull future when the streaming pull manager has already been shut down due to the error in the user callback.
How to test
Actual result (before the fix):
An error occurs during the shutdown:
Expected result (after the fix):
No internal error occurs during the shutdown, except for the error from the user callback, as expected.
PR checklist