This repository was archived by the owner on Mar 9, 2026. It is now read-only.
fix: process ErrorInfo / GRPC errors for ack/modack only when exactly-once delivery is enabled#626
Merged
anguillanneuf merged 7 commits intogoogleapis:mainfrom Mar 29, 2022
Merged
Conversation
Contributor
pradn
commented
Mar 28, 2022
- Don't process ErrorInfo / GRPC errors at all when exactly-once is disabled.
- Don't retry temporary errors for ack/modack RPCs when exactly-once is disabled
- Simplify completion of futures when a RetryError occurs (there's some duplication here but its simpler b/c we don't rely on subtle behavior in the process_errors function)
- Update tests / get to 100% test coverage
Loading
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.