Skip to content
This repository was archived by the owner on Mar 9, 2026. It is now read-only.

CI: add samples python 3.11 to required checks#950

Closed
liuyunnnn wants to merge 0 commit intogoogleapis:mainfrom
liuyunnnn:main
Closed

CI: add samples python 3.11 to required checks#950
liuyunnnn wants to merge 0 commit intogoogleapis:mainfrom
liuyunnnn:main

Conversation

@liuyunnnn
Copy link
Contributor

@liuyunnnn liuyunnnn commented Jul 13, 2023

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@liuyunnnn liuyunnnn requested a review from a team as a code owner July 13, 2023 19:21
@liuyunnnn liuyunnnn requested a review from a team July 13, 2023 19:21
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: pubsub Issues related to the googleapis/python-pubsub API. samples Issues that are directly related to samples. labels Jul 13, 2023
@liuyunnnn liuyunnnn changed the title add samples python 3.11 to required checks CI: add samples python 3.11 to required checks Jul 13, 2023
@conventional-commit-lint-gcf
Copy link

conventional-commit-lint-gcf bot commented Jul 13, 2023

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@dandhlee
Copy link
Contributor

dandhlee commented Jul 13, 2023

3.11 tests aren't added yet. Please ping me directly internally if this is required!

@liuyunnnn liuyunnnn closed this Jul 13, 2023
@product-auto-label product-auto-label bot added size: u Pull request is empty. and removed size: xs Pull request size is extra small. labels Jul 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@acocuzzo acocuzzo

Labels

api: pubsub Issues related to the googleapis/python-pubsub API. samples Issues that are directly related to samples. size: u Pull request is empty.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@liuyunnnn @dandhlee @acocuzzo