Make Places "textsearch" query parameter optional#399
Merged
jpoehnelt merged 1 commit intogooglemaps:masterfrom Mar 12, 2021
Merged
Make Places "textsearch" query parameter optional#399jpoehnelt merged 1 commit intogooglemaps:masterfrom
jpoehnelt merged 1 commit intogooglemaps:masterfrom
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
Codecov Report
@@ Coverage Diff @@
## master #399 +/- ##
=======================================
Coverage 89.19% 89.19%
=======================================
Files 13 13
Lines 731 731
=======================================
Hits 652 652
Misses 79 79
Continue to review full report at Codecov.
|
Contributor
Author
|
@googlebot I signed it! |
jpoehnelt
approved these changes
Mar 12, 2021
googlemaps-bot
pushed a commit
that referenced
this pull request
Mar 12, 2021
## [4.4.4](v4.4.3...v4.4.4) (2021-03-12) ### Bug Fixes * make Places textsearch query parameter optional ([#399](#399)) ([6b29efd](6b29efd))
Contributor
|
🎉 This PR is included in version 4.4.4 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This was referenced Mar 16, 2021
Marir19950304
pushed a commit
to Marir19950304/Google_map
that referenced
this pull request
Jan 25, 2022
## [4.4.4](googlemaps/google-maps-services-python@v4.4.3...v4.4.4) (2021-03-12) ### Bug Fixes * make Places textsearch query parameter optional ([#399](googlemaps/google-maps-services-python#399)) ([6b29efd](googlemaps/google-maps-services-python@6b29efd))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
queryparameter in the Places'textsearchAPI should be optional. Both as a fix for #395, but also more generally because the actual API supports calls without specifying the parameter.For example:
https://maps.googleapis.com/maps/api/place/textsearch/json?type=point_of_interest&location=43.8789781,-79.9714529&radius=10000&key={{ key }}No
queryparameter is specified, yet the request is completed successfully with no error and a result set.Fixes #395 🦕