Skip to content

fix: allow channel without client_id#411

Merged
jpoehnelt merged 2 commits intomasterfrom
fix/channel
Jul 14, 2021
Merged

fix: allow channel without client_id#411
jpoehnelt merged 2 commits intomasterfrom
fix/channel

Conversation

@jpoehnelt
Copy link
Copy Markdown
Contributor

closes #410

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jul 14, 2021
@codecov
Copy link
Copy Markdown

codecov bot commented Jul 14, 2021

Codecov Report

Merging #411 (e6ef4e6) into master (a9460c0) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #411      +/-   ##
==========================================
- Coverage   89.22%   89.19%   -0.03%     
==========================================
  Files          13       13              
  Lines         733      731       -2     
==========================================
- Hits          654      652       -2     
  Misses         79       79              
Impacted Files Coverage Δ
googlemaps/client.py 92.05% <ø> (-0.08%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9460c0...e6ef4e6. Read the comment docs.

@jpoehnelt jpoehnelt merged commit 6827645 into master Jul 14, 2021
@jpoehnelt jpoehnelt deleted the fix/channel branch July 14, 2021 15:40
googlemaps-bot pushed a commit that referenced this pull request Jul 14, 2021
## [4.4.6](v4.4.5...v4.4.6) (2021-07-14)

### Bug Fixes

* allow channel without client_id ([#411](#411)) ([6827645](6827645))
Marir19950304 pushed a commit to Marir19950304/Google_map that referenced this pull request Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Parameter client_id is required when using channels, but actually its not more required

2 participants