Skip to content

Add GraphiQL support#26

Merged
chris-ramon merged 5 commits intographql-go:masterfrom
cloudlena:feature/graphiql
Sep 12, 2017
Merged

Add GraphiQL support#26
chris-ramon merged 5 commits intographql-go:masterfrom
cloudlena:feature/graphiql

Conversation

@cloudlena
Copy link
Copy Markdown
Contributor

@cloudlena cloudlena commented Aug 23, 2017 •
edited
Loading

I took the template from https://github.com/graphql/express-graphql/blob/master/src/renderGraphiQL.js and go-ified it.

@sogko and others: Please let me know what you think.

If you like it, I'll add the necessary tests and make the code cleaner.

I've had some trouble adding ResultString and VariablesString. I would be glad about some advice about where to get them.

@cloudlena cloudlena mentioned this pull request Aug 23, 2017
Open
@coveralls
Copy link
Copy Markdown

coveralls commented Aug 23, 2017 •
edited
Loading

Coverage Status

Coverage decreased (-15.06%) to 79.389% when pulling 17cb4b0 on mastertinner:feature/graphiql into fab5288 on graphql-go:master.

@coveralls
Copy link
Copy Markdown

coveralls commented Aug 24, 2017 •
edited
Loading

Coverage Status

Coverage decreased (-17.4%) to 77.037% when pulling 5bc47c0 on mastertinner:feature/graphiql into fab5288 on graphql-go:master.

@coveralls
Copy link
Copy Markdown

coveralls commented Aug 24, 2017 •
edited
Loading

Coverage Status

Coverage decreased (-17.4%) to 77.037% when pulling e9334dc on mastertinner:feature/graphiql into fab5288 on graphql-go:master.

@yookoala
Copy link
Copy Markdown
Contributor

yookoala commented Aug 24, 2017

This seems nice. Please do merge.

@coveralls
Copy link
Copy Markdown

coveralls commented Aug 26, 2017 •
edited
Loading

Coverage Status

Coverage decreased (-23.4%) to 71.141% when pulling 24733ec on mastertinner:feature/graphiql into 43051ba on graphql-go:master.

@coveralls
Copy link
Copy Markdown

coveralls commented Aug 27, 2017 •
edited
Loading

Coverage Status

Coverage decreased (-5.7%) to 88.889% when pulling 70ee617 on mastertinner:feature/graphiql into 43051ba on graphql-go:master.

@coveralls
Copy link
Copy Markdown

coveralls commented Aug 27, 2017 •
edited
Loading

Coverage Status

Coverage decreased (-7.4%) to 87.179% when pulling ce8e677 on mastertinner:feature/graphiql into 43051ba on graphql-go:master.

@coveralls
Copy link
Copy Markdown

coveralls commented Aug 27, 2017 •
edited
Loading

Coverage Status

Coverage decreased (-7.3%) to 87.261% when pulling e2a07d5 on mastertinner:feature/graphiql into 43051ba on graphql-go:master.

@cloudlena
Copy link
Copy Markdown
Contributor Author

cloudlena commented Aug 27, 2017

I resolved the problems mentioned above and added tests so I think this can be merged now.

@cloudlena
Copy link
Copy Markdown
Contributor Author

cloudlena commented Aug 28, 2017

@sogko, can you please comment or merge?

@yookoala
Copy link
Copy Markdown
Contributor

yookoala commented Aug 29, 2017

Added comment here. No respond yet.

@ulm0
Copy link
Copy Markdown

ulm0 commented Sep 9, 2017

where can the ui be reached? i'm going to /graphiql but i get a 404. thanks in advance

@cloudlena
Copy link
Copy Markdown
Contributor Author

cloudlena commented Sep 9, 2017

@klud1, it's at the same URL where your graphql endpoint is. If you reach it with a browser, it will return the GraphiQL GUI.

@ulm0
Copy link
Copy Markdown

ulm0 commented Sep 9, 2017

Alright, it's working! Thanks, awesome work! Hope this gets merged asap so i don't have to tweak my build process in order to get these changes.

@chris-ramon
Copy link
Copy Markdown
Member

chris-ramon commented Sep 12, 2017

LGTM 👍 — this is really awesome, thanks a lot @mastertinner! 🚢

@chris-ramon chris-ramon merged commit fb144b8 into graphql-go:master Sep 12, 2017
@cloudlena cloudlena deleted the feature/graphiql branch September 12, 2017 07:18
@cloudlena
Copy link
Copy Markdown
Contributor Author

cloudlena commented Sep 12, 2017

Thanks for merging, @chris-ramon! Could you create a new release 0.2.0 which contains GraphiQL?

@chris-ramon
Copy link
Copy Markdown
Member

chris-ramon commented Sep 12, 2017

Thanks for merging, @chris-ramon! Could you create a new release 0.2.0 which contains GraphiQL?

Sure thing!, https://github.com/graphql-go/handler/releases/tag/v0.2.0

@cloudlena
Copy link
Copy Markdown
Contributor Author

cloudlena commented Sep 12, 2017

Nice! Thanks, @chris-ramon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@cloudlena @coveralls @yookoala @ulm0 @chris-ramon