Extract checksums regardless of length and account for sha1 encryption.#45
Merged
SherifMesallam merged 3 commits intomasterfrom Dec 19, 2024
Merged
Extract checksums regardless of length and account for sha1 encryption.#45SherifMesallam merged 3 commits intomasterfrom
sha1 encryption.#45SherifMesallam merged 3 commits intomasterfrom
Conversation
gosiapado
requested changes
Dec 19, 2024
gosiapado
left a comment
There was a problem hiding this comment.
@SherifMesallam, I'm still seeing the same warnings. Can you take a look at my screencast and give me some feedback? Not sure if I'm doing something wrong or not doing something. Details on sheet. Thanks.
richardW8k
approved these changes
Dec 19, 2024
Member
richardW8k
left a comment
There was a problem hiding this comment.
just one minor code style issue
gosiapado
approved these changes
Dec 19, 2024
gosiapado
left a comment
There was a problem hiding this comment.
Thanks to @richardW8k, for helping me work through my issue.
I'm seeing the expected success message now 👍.
Co-authored-by: Richard Wawrzyniak <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This issue resolves gravityforms/backlog#5741 by doing the following:
Testing instructions
cd app/public/wp-content/plugins/gravityformswp gf tool verify-checksumsQA issue tracking sheet