Skip to content

Extract checksums regardless of length and account for sha1 encryption.#45

Merged
SherifMesallam merged 3 commits intomasterfrom
fix-5741-verify-checksums
Dec 19, 2024
Merged

Extract checksums regardless of length and account for sha1 encryption.#45
SherifMesallam merged 3 commits intomasterfrom
fix-5741-verify-checksums

Conversation

@SherifMesallam
Copy link
Copy Markdown
Contributor

@SherifMesallam SherifMesallam commented Dec 19, 2024

Description

This issue resolves gravityforms/backlog#5741 by doing the following:

  1. Updates how the checksum is extracted from the checksum string regardless of the checksum string length.
  2. Depending on the length, it decides the encryption method used to generate the checksums and use when checking the files against the checksums.

Testing instructions

  1. Download the latest gravityforms build from gravityform.com (don't use the repo, we need that downloadable version in particular)
  2. Use this branch for gravitycli
  3. Make sure gravity cli is activated
  4. From local, right click on the website and from the menu click "open site shell"
  5. In the terminal type cd app/public/wp-content/plugins/gravityforms
  6. Then type this command wp gf tool verify-checksums
  7. After the command has been executed (it takes a couple of seconds) you should get the following success message :"Success: Gravity Forms install verifies against checksums."

QA issue tracking sheet

@SherifMesallam SherifMesallam requested review from a team December 19, 2024 14:46
@gosiapado gosiapado requested review from gosiapado and removed request for a team December 19, 2024 15:21
Copy link
Copy Markdown

@gosiapado gosiapado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SherifMesallam, I'm still seeing the same warnings. Can you take a look at my screencast and give me some feedback? Not sure if I'm doing something wrong or not doing something. Details on sheet. Thanks.

@gosiapado gosiapado self-requested a review December 19, 2024 16:48
Copy link
Copy Markdown
Member

@richardW8k richardW8k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one minor code style issue

Copy link
Copy Markdown

@gosiapado gosiapado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks to @richardW8k, for helping me work through my issue.
I'm seeing the expected success message now 👍.

Co-authored-by: Richard Wawrzyniak <[email protected]>
@SherifMesallam SherifMesallam merged commit 670c27f into master Dec 19, 2024
@SherifMesallam SherifMesallam deleted the fix-5741-verify-checksums branch December 19, 2024 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants