Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
Completing the assignment by writing my own version of anagram checker for both parts. Each function has a docstring comment that explains what the function does.
What did you learn from the changes you have made?
During the live learning sessions I was able to learn more about proper commenting best practices as well as logic flow.
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
When I was coding each of the functions, there are multiple ways that it could have been done so I tried to get one that worked first and then look for ways that I could have simplified the code.
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
Most of the time the syntax errors get in the way of testing and seeing if the functions work. Most of the time the error messages are clear about what to fix but if not, a quick google search about the syntax solves the issue.
How were these changes tested?
The functions were tested using the predefined tests outlined in the assignment directions. I also wrote one additional test for part two of the assignment.
A reference to a related issue in your repository (if applicable)
Checklist