Skip to content

Fallback for parse qsl#89

Merged
grisha merged 2 commits intogrisha:masterfrom
rohan-97:fallback_for_parse_qsl
Mar 4, 2020
Merged

Fallback for parse qsl#89
grisha merged 2 commits intogrisha:masterfrom
rohan-97:fallback_for_parse_qsl

Conversation

@rohan-97
Copy link
Copy Markdown

@rohan-97 rohan-97 commented Mar 4, 2020

On Python3, parse_qsl fails while decoding string to UTF8.
and Exception is raised when we run parse_qsl.

However in python3, urllib.parse module provides same function which works fine when compiled with python3.

signature of parse_qsl method from _apachemodule.c and urllib.parse is same and both provides same functionality.

Hence adding parse_qsl function from urllib.parse module as a fallback if an exception is raised from parse_qsl method from _apachemodule.c

@grisha grisha merged commit 25d6290 into grisha:master Mar 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants