Add commons commands from package-zookeeper and package-kafka#14
Merged
brikis98 merged 5 commits intogruntwork-io:masterfrom Mar 5, 2019
Merged
Conversation
brikis98
reviewed
Mar 4, 2019
Member
brikis98
left a comment
There was a problem hiding this comment.
This is fantastic, thank you! 👍
ed4eb52 to
ce6f0c5
Compare
brikis98
reviewed
Mar 4, 2019
Member
brikis98
left a comment
There was a problem hiding this comment.
One last fix and this is good to merge 👍
brikis98
approved these changes
Mar 5, 2019
Member
brikis98
left a comment
There was a problem hiding this comment.
Wonderful, thank you! Merging now and will let the tests run. If they pass, I'll issue a new release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both the Zookeeper and Kafka packages have forks of bash-commons. This is my attempt to merge them all back into a single place. I have patches for package-zookeeper and package-kafka that use this new, combined bash-commons pending this merge.
I added tests where I could. Unfortunately, moto doesn't support enis afaik so I was unable to add tests for the eni functions I copied over.
Everything else should have a test and is confirmed to pass.