Add function to get instance with specific tags#6
Merged
Conversation
brikis98
reviewed
Aug 31, 2018
Member
brikis98
left a comment
There was a problem hiding this comment.
Code looks good, but please add a test in the tests folder!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is meant to address a need in https://github.com/gruntwork-io/package-elk/pull/43. Specifically this comment https://github.com/gruntwork-io/package-elk/pull/43#discussion_r213864939 about using tags to retrieve IPs instead of ASG names.
The PR includes the following:
aws_get_instances_with_tagwithinaws.shthat simply returns the json result from the call to theaws-cliaws_wrapper_get_ips_with_tagwithinaws-wrapper.shthat calls theaws_get_instances_with_tagfunction and returns the public or private IPs of the instances