Add support for codeception 4 + DrupalFinder#7
Merged
guncha25 merged 2 commits intoguncha25:8.xfrom Jul 8, 2020
Merged
Conversation
Add webdriver module dependency
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds codeception 4 support. Nothing in the code really needed to change other than the extra composer dependencies required for webdriver to work. I didn't notice anything else breaking but I certainly didn't test every option. But login, create entity, and similar actions still work.
Not sure how you want to handle the new deps since codeception/module-webdriver likely won't install on earlier versions. If you want to create a new major branch release or what.
This also includes a change to automatically discover Drupal's webroot using DrupalFinder. I can split this out if you want but that's really the only code change.