[fastcgi] environment variable overwrites HTTP_*#996
Merged
Conversation
5681f5a to
fd2d45c
Compare
Contributor
|
@kazuho Do you intend to release a new 2.0.x version including this patch (or else 2.1)? Or do we have to upgrade to current in order to get protection against httpoxy? |
kazuho
added a commit
that referenced
this pull request
Jul 29, 2016
[fastcgi] environment variable overwrites `HTTP_*`
Member
Author
|
@utrenkner Sorry for the delay. Just released 2.0.2. |
Contributor
|
@kazuho Thank you. I updated our server and issued a pull request to httpoxy.org to include the h2o related mitigation httpoxy/httpoxy-org#20 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In current implementation, environment variables set using
setenvconfiguration directive does not overwrite the received HTTP request headers. The bug makes us impossible to use the directive to block attacks trying to exploit httpoxy vulnerability.This PR is a quick fix for the issue so that we can use the directive to prevent the attack.
Note that there are other issues in how we build FastCGI request parameters:
setenvcannot cannot rewrite specially-treated headers likeHTTP_HOSTunsetenvcannot be used for resettingHTTP_*, etc.So we might fix all these issues at once, depending on how long it would take.
relates to #994